Conversation
…mock data as arguments to avoid code repeats
There was a problem hiding this comment.
Pull Request Overview
This PR adds unit tests for the search_companies function and wires pytest into project configuration and CI.
- Introduces comprehensive tests for exact, fuzzy, no-match, and NaN handling behaviors in
tests/services/test_search.py. - Updates project setup to declare pytest as a dependency, document the test command, and run tests in CI.
- Adds a test helper fixture in
tests/conftest.pyfor importing the application.
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/services/test_search.py | Added unit tests covering exact, fuzzy, no-match, and NaN scenarios for search_companies. |
| tests/conftest.py | Inserted sys.path modification to make the app module importable in tests. |
| pyproject.toml | Declared pytest as a dependency. |
| README.md | Documented the poetry run pytest command under a new test section. |
| .github/workflows/ci.yml | Added a step to run pytest in the CI pipeline. |
Comments suppressed due to low confidence (2)
tests/services/test_search.py:44
- [nitpick] Consider adding a test to verify case-insensitive matching (e.g., searching 'foo' still matches 'Foo Company') to ensure consistency.
def test_fuzzy_match(patch_skilled_worker_data_current, mock_data):
.github/workflows/ci.yml:39
- [nitpick] Consider adding a coverage reporting step (e.g., using
pytest-cov) and enforcing coverage thresholds to track and maintain test coverage in CI.
- name: Run pytest (testing)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add unit tests for search.py